Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for S3 logging. #4482

Closed
wants to merge 1 commit into from

Conversation

kjmkznr
Copy link
Contributor

@kjmkznr kjmkznr commented Jan 2, 2016

This commit is allows to logging configuration to S3 bucket resource.

  • Test
$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSS3Bucket_Logging' 2> /dev/null
==> Checking that code complies with gofmt requirements...
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSS3Bucket_Logging -timeout 90m
=== RUN   TestAccAWSS3Bucket_Logging
--- PASS: TestAccAWSS3Bucket_Logging (13.55s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    13.559s
  • Example
resource "aws_s3_bucket" "log_bucket" {
   bucket = "my_tf_log_bucket"
   acl = "log-delivery-write"
}
resource "aws_s3_bucket" "b" {
   bucket = "my_tf_test_bucket"
   acl = "private"
   logging {
       target_bucket = "${aws_s3_bucket.log_bucket.id}"
       target_prefix = "log/"
   }
}

@kjmkznr kjmkznr changed the title Add support for S3 logging. provider/aws: Add support for S3 logging. Jan 5, 2016
@jen20
Copy link
Contributor

jen20 commented Jan 9, 2016

Thanks @kjmkznr! I've manually merged this after a rebase and fixing up the wording of the documentation - the style was wrong in many of the documentation of the blocks for a while now. Great work!

@jen20 jen20 closed this Jan 9, 2016
@jen20
Copy link
Contributor

jen20 commented Jan 9, 2016

Your commit landed (after rebase) as f2ce28e.

@kjmkznr
Copy link
Contributor Author

kjmkznr commented Jan 12, 2016

Thanks!

@kjmkznr kjmkznr deleted the aws-s3-logging branch January 12, 2016 02:38
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants