provider/aws: Fix issue with detecting drift in AWS Security Groups rules #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Users upgrading to this may see non empty plans related to security groups. While unfortunate, it's actually correct... without this patch drift or other changes are being ignored |
4 tasks
|
LGTM |
catsby
added a commit
that referenced
this pull request
Jan 25, 2016
provider/aws: Fix issue with detecting drift in AWS Security Groups rules
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
resourceAwsSecurityGroupIPPermGathermethod to correctly create the Ingress/Egress TypeSet need to store the data locally. #4741 revealed that ingress/egress rules were not actually being stored onReadof a Security Group. There was an error withd.Set("ingress")(and egress) that was being ignored, and as a result whatever was in the configuration file remained unchanged since the first initial set on create.This prevented drift from being detected, e.g. an additional rule being added on the AWS Console.
The crux of it was that
resourceAwsSecurityGroupIPPermGatherwould return a slice of security group Ids, which was not compatible with theTypeSetthat it was supposed to be.This PR fixes that by correctly formatting the
[]map[string]interface{}returned from the method to include the Set of security groups, instead of a slice of strings.Fixes #4741