Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/digitalocean: Adds a FQDN out to the digitalocean_record #5071

Merged
merged 1 commit into from
Feb 22, 2016
Merged

provider/digitalocean: Adds a FQDN out to the digitalocean_record #5071

merged 1 commit into from
Feb 22, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 9, 2016

resource. This is a computed field

Fixes #5064

make testacc TEST=./builtin/providers/digitalocean TESTARGS='-run=DigitalOceanRecord_Basic' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/digitalocean -v -run=DigitalOceanRecord_Basic -timeout 120m
=== RUN   TestAccDigitalOceanRecord_Basic
--- PASS: TestAccDigitalOceanRecord_Basic (3.79s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/digitalocean   3.801s

@stack72 stack72 changed the title provider/digitalocean: Addsa FQDN out to the digitalocean_record provider/digitalocean: Adds a FQDN out to the digitalocean_record Feb 11, 2016
jen20
jen20 reviewed Feb 22, 2016
View reviewed changes
builtin/providers/digitalocean/resource_digitalocean_record.go
@@ -146,6 +151,10 @@ func resourceDigitalOceanRecordRead(d *schema.ResourceData, meta interface{}) er
d.Set("priority", strconv.Itoa(rec.Priority))
d.Set("port", strconv.Itoa(rec.Port))

en := constructFqdn(rec.Name, d.Get("domain").(string))
log.Printf("[DEBUG] Constructred FQDN: %s", en)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here

@jen20
Copy link
Contributor

jen20 commented Feb 22, 2016

Merged! Thanks @stack72.

@jen20 jen20 merged commit b57a309 into hashicorp:master Feb 22, 2016
@stack72 stack72 deleted the f-digitalocean-record-fqdn branch February 22, 2016 18:40
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/digitalocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FQDN output to digitalocean_record resource types
2 participants
@stack72 @jen20