provider/test: a test provider #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes a covering test for #5635, so it won't go green until that's merged. |
phinze
force-pushed
the
phinze/test-provider
branch
3 times, most recently
from
06b6b3c
to
3c7b0a7
Compare
|
(Removed additional test so I can land this as-is and rebase over it.) |
Here we also introduce a `test` provider meant as an aid to exposing via automated tests issues involving interactions between `helper/schema` and Terraform core. This has been helpful so far in diagnosing `ignore_changes` problems, and I imagine it will be helpful in other contexts as well. We'll have to be careful to prevent the `test` provider from becoming a dumping ground for poorly specified tests that have a clear home elsewhere. But for bug exposure I think it's useful to have.
phinze
force-pushed
the
phinze/test-provider
branch
from
3c7b0a7
to
c3e27b3
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we also introduce a
testprovider meant as an aid to exposingvia automated tests issues involving interactions between
helper/schemaand Terraform core.This has been helpful so far in diagnosing
ignore_changesproblems,and I imagine it will be helpful in other contexts as well.
We'll have to be careful to prevent the
testprovider from becoming adumping ground for poorly specified tests that have a clear home
elsewhere. But for bug exposure I think it's useful to have.