Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] rough changes that fix vsphere vm's on master #6547

Closed
wants to merge 3 commits into from

Conversation

knuckolls
Copy link
Contributor

@knuckolls knuckolls commented May 9, 2016

I'm not sure if this should be merged in it's current form but I wanted to put this out there so people could see what I had to do to get vSphere vms working today.

Currently master pulls the network information too soon thus if anything wants to subsequently use the IP of the instance it fails. I believe this is documented in #6174 and this PR is a really rough fix for the problem. I solved this by adding in a loop that spins until the network information is not null. This probably needs a circuit breaker after some amount of time but it's effective.

I also am not sure if this would work at all with DHCP. It does work when all the addressing information is passed in statically. Furthermore, this fix (#6522) for pulling in the gateway routing information flat out didn't work for me (and I debugged it for hours) so I statically set the gateway based upon what's passed in from the configuration.

Hopefully someone finds this helpful. I'm going to use it as a stopgap for my purposes.

@knuckolls
Copy link
Contributor Author

cc: @chrislovecnm. You seem to be commenting on all of the vSphere issues / PR's surrounding getting master to work. Thought you might find this useful as a starting point for a more robust solution.

@thetuxkeeper
Copy link
Contributor

Hi @knuckolls,
can you try #6479 + #6377 that should fix the problem, but it is blocked by some other issues. We try to fix the acceptance tests first (that we can be sure it doesn't break other stuff) and ran into further issues (like #6522 and #6520).

@chrislovecnm
Copy link
Contributor

@knuckolls thanks for the work. So we believe that there is a way to do this in the API - I am @ the airport so I cannot go into details.

I think we may have a better way to do this ;)

Again thanks for your work. We appreciate you committing and if you are interested in helping more, we definitely can use you help. Let me know if you want to coordinate more.

@chrislovecnm
Copy link
Contributor

@knuckolls does #6377 address these problems? If so please close out this PR. BTW thanks for contributing, if you have an opportunity to help out, we have stuff to do :)

@stack72
Copy link
Contributor

stack72 commented Aug 15, 2016

Hi @knuckolls / @chrislovecnm

Any thoughts on the status of this PR is this still needed or has #6377 got this covered?

Paul

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Aug 15, 2016
@mitchellh
Copy link
Contributor

Hello! I'm going through waiting-response labeled issues and closing issues that haven't been responded to with a meaningful response in at least 2+ weeks. If this is still an issue, please open a new issue so we can start anew. Feel free to reference this existing issue to make a link between the two. Thanks!

@mitchellh mitchellh closed this Dec 1, 2016
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug provider/vsphere waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants