Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/fastly: add support for custom VCL configuration (supersedes #6587) #6662

Merged
merged 3 commits into from
May 17, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented May 13, 2016

Builds on #6587 by adding an acceptance test, which the original was lacking simply because your account must have custom VCL support enabled

@mattmoyer
Copy link
Contributor

Thanks for finishing this! Tests look good to me.

@catsby
Copy link
Contributor Author

catsby commented May 17, 2016

Tests are passing after a rebase:

TF_ACC=1 go test ./builtin/providers/fastly -v -run=TestAccFastlyServiceV1_ -timeout 120m
=== RUN   TestAccFastlyServiceV1_conditional_basic
--- PASS: TestAccFastlyServiceV1_conditional_basic (14.66s)
=== RUN   TestAccFastlyServiceV1_gzips_basic
--- PASS: TestAccFastlyServiceV1_gzips_basic (28.99s)
=== RUN   TestAccFastlyServiceV1_headers_basic
--- PASS: TestAccFastlyServiceV1_headers_basic (29.51s)
=== RUN   TestAccFastlyServiceV1_s3logging_basic
--- PASS: TestAccFastlyServiceV1_s3logging_basic (28.75s)
=== RUN   TestAccFastlyServiceV1_s3logging_s3_env
--- PASS: TestAccFastlyServiceV1_s3logging_s3_env (12.67s)
=== RUN   TestAccFastlyServiceV1_updateDomain
--- PASS: TestAccFastlyServiceV1_updateDomain (29.71s)
=== RUN   TestAccFastlyServiceV1_updateBackend
--- PASS: TestAccFastlyServiceV1_updateBackend (28.25s)
=== RUN   TestAccFastlyServiceV1_basic
--- PASS: TestAccFastlyServiceV1_basic (12.75s)
=== RUN   TestAccFastlyServiceV1_disappears
--- PASS: TestAccFastlyServiceV1_disappears (7.18s)
=== RUN   TestAccFastlyServiceV1_VCL_basic
--- PASS: TestAccFastlyServiceV1_VCL_basic (28.87s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/fastly 221.365s
Test:

@catsby catsby merged commit 073f629 into master May 17, 2016
@catsby catsby deleted the pr-6587 branch May 17, 2016 19:49
ojongerius added a commit to atlassian/terraform that referenced this pull request May 18, 2016
…equire_full_window_and_locked

* upstream/master: (665 commits)
  merged createVirtualMachine and deployVirtualMachine to setupVirtualMachine (hashicorp#6659)
  Update CHANGELOG.md
  provider/fastly: add support for custom VCL configuration (supersedes hashicorp#6587) (hashicorp#6662)
  Remove CHANGELOG entry for backported 0.6.17 feature
  Update CHANGELOG.md
  provider/vsphere: wait for network enhanced (hashicorp#6377)
  Update CHANGELOG.md
  Update CHANGELOG.md
  Update CHANGELOG.md
  docs: clarify an internal-plugins header
  Fixes an vet error.
  Update CHANGELOG.md
  provider/aws: Support for Redshift Cluster encryption using a KMS key (hashicorp#6712)
  provider/aws: Randomize key names in KMS alias test
  Include the list of allowed values for AWS auto scaling group termination policies (hashicorp#6710)
  website: docs for azurerm custom images
  Update CHANGELOG.md
  Godeps: rm dup github.com/ryanuber/columnize
  Add note about paid training
  provider/aws: Fix crash in ElastiCache param group
  ...
cristicalin pushed a commit to cristicalin/terraform that referenced this pull request May 24, 2016
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants