Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct true and false OpsWorks string values to fix manage_bundler config bug #7219

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

dlanner
Copy link
Contributor

@dlanner dlanner commented Jun 17, 2016

This PR implements the small change provided by @u2mejc in his comment on issue #5907, in order to fix a bug where the aws_opsworks_rails_app_layer resource's manage_bundler parameter is ignored, so no matter if you set it to true, false, or don't even set it, the created Rails layer's "Install and manage Bundler" setting is unconditionally "No".

There are no existing acceptance tests for resource_aws_opsworks_rails_app_layer. Unfortunately, I don't have the time to write them, although it seems like it would be a good opportunity to learn a little Go.

But I did compile Terraform in Vagrant (make dev) with this change and tested my Terraform template file which set manage_bundler = true, and it resulted in the created Rails layer having "Install and manage Bundler" set to "yes". So it does fix that issue, as @u2mejc said.

@stack72
Copy link
Contributor

stack72 commented Jun 29, 2016

Hi @dlanner

Thanks so much for this PR - this LGTM!

Paul

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants