command: more resilient HCL check for inputs #8620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // matches what we'd expect a rich HCL value to be. For example: { | ||
| // definitely signals a map. If a value DOESN'T match this, we return | ||
| // it as a raw string. | ||
| varFlagHCLRe = regexp.MustCompile(`^["\[\{]`) |
There was a problem hiding this comment.
I think previously we would have allowed whitespace at the start of the string, so this is somewhat different.
Edit: just saw it compared with strings.TrimSpace, ignore.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8044
This introduces a more resilient check when parsing variable values as HCL for determining if they were really HCL or not. Before, we simply checked error message (I kept this around although it may no longer be necessary). Now, I check for certain starting symbols ignoring whitespace:
[- List{- Map"- StringIf it DOESN'T have one of those, we return as-is.
Existing tests pass. I want to double check with @jen20 if this is enough.