Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded Ruby to 2.5.3 #145

Closed
wants to merge 5 commits into from

Conversation

syndbg
Copy link

@syndbg syndbg commented Nov 26, 2018

@chrisroberts

TODO:

  • Verify that Ruby 2.4.0 is completely removed. Looks good to me, though.

What's been tested:

Fixes error message

```
ubuntu-14.04: ubuntu_x86_64
ubuntu-14.04:   -> Readying build directories...
ubuntu-14.04:   -> Installing any required packages...
ubuntu-14.04: dpkg-preconfigure: unable to re-open stdin: No such file or directory
```
@chrisroberts
Copy link
Member

Hi there,

Thank you for this PR, however it is missing updates for the Ruby version provided in the Windows packaging as well as the appimage package. We are also not yet ready to upgrade the Ruby version to the 2.5 series.

I did test the vagrant-libvirt plugin on ubuntu 18.04 and found that the appimage version did have problems properly locating and building the plugin extensions. However, using the deb package for install worked as expected. I will investigate why the appimage version is failing and get that fixed up in the next release.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants