Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax childprocess dependency restriction. #10898

Closed
wants to merge 1 commit into from

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Jun 7, 2019

Testing against childprocess 1.0.1, the test suite is passing just fine.

The newer childprocess might fix issues such as #10801

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@voxik
Copy link
Contributor Author

voxik commented Jun 7, 2019

The test suite passed.

I am not going to sing CLA, so do whatever you need to do ...

@briancain
Copy link
Member

Hi @voxik - thanks for making a PR. HashiCorp requires all contributors sign the CLA, so if that's the case I'll close this PR. We would also likely want to be more explicit about what version of childprocess we are using rather than that wide range of versions if the newer 1.0.x version does solve the encoding issue on windows.

@briancain briancain closed this Jun 7, 2019
@voxik
Copy link
Contributor Author

voxik commented Jun 7, 2019

I would prefer if you are not that explicit. If you were not that explicit, windows users would have the bug fixed a while ago.

Also the strict versions are troubling us on Fedora, because we have to relax the dependencies, while the resolver does not respect local gems and is using upstream dependency info for resolution instead, making the result incompatible.

@ghost
Copy link

ghost commented Jan 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants