Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update childprocess gem #11487

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Apr 2, 2020

childprocess v 1.x includes a fix for encoding on Windows
enkessler/childprocess#134
This was previously causing errors on Windows hosts

childprocess v 1.x includes a fix for encoding on Windows
enkessler/childprocess#134
This was previously causing errors on Windows hosts
@soapy1
Copy link
Contributor Author

soapy1 commented Apr 2, 2020

I think this also requires an update to vagrant-spec
hashicorp/vagrant-spec#33

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soapy1 soapy1 merged commit 522dd6a into hashicorp:master Apr 6, 2020
@soapy1 soapy1 deleted the update-childprocess-gem branch April 6, 2020 14:15
@ghost
Copy link

ghost commented May 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants