docs: add namespace example to readme #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
force-pushed
the
docs/readme-namespace-example
branch
3 times, most recently
from
c17bd0d
to
bf290df
Compare
fairclothjm
force-pushed
the
docs/readme-namespace-example
branch
from
bf290df
to
c019897
Compare
benashz
approved these changes
Jul 31, 2024
| @@ -496,6 +495,25 @@ steps: | |||
| secret/data/ci npm_token | |||
| ``` | |||
|
|
|||
| Alternatively, you may need to authenticate to the root namespace and retrieve | |||
| a secret from a different namespace. To do this, do not set the `namespace` | |||
There was a problem hiding this comment.
Interesting, did the namespace param work before?
There was a problem hiding this comment.
The namespace param is used to authenticate to Vault. We haven't made any changes there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559
the tests were failing due to the jwt auth's recent behavior change in 1.17 so that is fixed here as well. See https://developer.hashicorp.com/vault/docs/upgrading/upgrade-to-1.17.x#jwt-auth-login-requires-bound-audiences-on-the-role