-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send a test message before committing a new audit device. #10520
Conversation
Also, lower timeout on connection attempts in socket device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just a few comments and things I'd like to know.
writer = os.Stdout | ||
case "discard": | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a default case? otherwise i'd think writer
could be nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
writer can be nil, but confusingly for this backend the log
function uses open() when it is
Also, lower timeout on connection attempts in socket device.
Some history here:
The test message looks like this: