Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure MSI endpoint #10624

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Update Azure MSI endpoint #10624

merged 5 commits into from
Jun 4, 2024

Conversation

mbrancato
Copy link
Contributor

@mbrancato mbrancato commented Dec 27, 2020

Update the MSI endpoint appropriate for either App Service or instance metadata. Fixes Azure storage with MSI on App Service.

Fixes #10623

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

(For others, ref to the new function: adal/token.go)

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 6, 2022

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


3 out of 4 committers have signed the CLA.

  • tomcf-hcp
  • VioletHynes
  • mbrancato
  • Jim Kalafut

Jim Kalafut seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! This looks reasonable enough to me. It seems that both of these have been deprecated since, but the suggested change makes it better, as I understand it. I'll see about getting this merged. Sorry that this waited for so long!

Thanks for the contribution!

@tomcf-hcp tomcf-hcp merged commit af47fc9 into hashicorp:main Jun 4, 2024
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure MSI support doesn't support App Service
7 participants