make token create case insensitive [VAULT-1021] #10743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2021 12:58
mgritter
approved these changes
Jan 21, 2021
Comment on lines
110
to
114
| been specified, the entity will not be inherited from the parent. Note that | ||
| `allowed_entity_aliases` is not case sensitive. For example, creating tokens | ||
| with alias `aLiAs` and alias `alias` will both succeed even if the | ||
| `allowed_entity_aliases` list only allows for token creation for entity alias | ||
| `alias`. |
There was a problem hiding this comment.
I think this is a bit wordy, I would maybe note in allowed_entity_aliases that the matching is not case-sensitive.
|
This pull request is being automatically deployed with Vercel (learn more). vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/elozqdr8v |
mgritter
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hashicorp.atlassian.net/browse/VAULT-1021
This allows for tokens creation to be case insensitive against allowed aliases. Previously there was a mix of case sensitivity and case insensitivity, so mixed case aliases were disallowed. Note that entity aliases will still retain their case sensitivity internally, but for every verification step, they will be checked in a case-insensitive way.