UI/okta duo push notification #11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Monkeychip. I'd like to chat about this since the design has moved a bit from the original idea of displaying a message after a certain amount of time. |
hashishaw
approved these changes
Apr 23, 2021
hashishaw
reviewed
May 4, 2021
| @@ -105,4 +105,17 @@ module('Acceptance | auth', function(hooks) { | |||
| await visit('/vault/access'); | |||
| assert.dom('[data-test-allow-expiration="true"]').doesNotExist('hides beacon when the api is used again'); | |||
| }); | |||
|
|
|||
| test('it shows the push notification warning only for okta auth method after submit', async function(assert) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a push notification for Okta authentication. There have been issues with people waiting for the loader, not knowing that it was actually the loader waiting on them to hit their okta push notifications.
Functionality: If you select the auth method "okta" a function called
delayAuthMessageReminderis fired concurrently while theauthenticateconcurrency task is also running. If after five seconds theauthenticateconcurrency task is still running a message appears to remind folks to check their push notifications. If the auth method takes less than five seconds (ex: you have okta setup with no MFA and its successful) you won't see the message reminder.Here is a gif of a situation in which we wait 90 seconds for someone to hit their push notifications.
Here is a gif of a situation where it takes less than 5 seconds to login to okta and you do not see the message.
Here is a screenshot of the message:
Note:
While I was in there, I removed the overlay loader per Design's request— we show this with a grey out readOnly button that has a spinning loading inside of it. I also cleaned up the look of the
AlertInlinecomponent that display messages for the JWT method and for under "More options". The messages now match the font-size and padding that Design had specked the Okta notification message for.