Vault 1979: Query API for Irrevocable Leases

[swayne275]

No description provided.

[sgmiller]

I think this is fine, but we could also sort by expiration time then lease id, so the operator can get a sense of how old the oldest irrevocable leases are.

[swayne275]

yeah that sounds like a good idea

[swayne275]

23a1082

[sgmiller]

Other way around on that sort? I think you want to do it in just one pass with the sort predicate testing expiration time and returning if non-equal, then testing leaseid if the expiration times are equal.

[swayne275]

can you clarify how you'd like this sorted? the current code will display the oldest-expiring leases at the top of the list, and if multiple leases have the same expiration time it will then display them in increasing order by the lease id (a comes before b)

i can certainly do it in one slice sort path, but let's verify how we want the results displayed first

[swayne275]

we chatted in slack. sorting is correct, but made more efficient here: 585caea

[sgmiller]

Other way around on that sort? I think you want to do it in just one pass with the sort predicate testing expiration time and returning if non-equal, then testing leaseid if the expiration times are equal.