Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.8.x: Cap AWS Token TTL based on Default Lease TTL (#12026) #12252

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

vinay-gopalan
Copy link
Contributor

  • Removes TTL cap warning if Token TTL is greater than the defaultLeaseTTL since capping isn't necessary
  • Fixes typos in error messages in tests

* fix: cap token TTL at login time based on default lease TTL

* add changelog file

* patch: update warning messages to not include 'at login'

* patch: remove default lease capping and test

* update changelog

* patch: revert warning message
@vinay-gopalan vinay-gopalan requested a review from a team August 4, 2021 17:19
@vinay-gopalan vinay-gopalan reopened this Aug 4, 2021
@vinay-gopalan vinay-gopalan changed the base branch from main to release/1.8.x August 4, 2021 17:19
@calvn calvn added this to the 1.8.1 milestone Aug 4, 2021
@calvn calvn merged commit d4269f3 into release/1.8.x Aug 4, 2021
@calvn calvn deleted the backport-pr-12026-1.8.x branch August 4, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants