Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-3226] Use os.rename on windows os #12377

Merged
merged 2 commits into from
Aug 19, 2021
Merged

[VAULT-3226] Use os.rename on windows os #12377

merged 2 commits into from
Aug 19, 2021

Conversation

pmmukh
Copy link
Contributor

@pmmukh pmmukh commented Aug 19, 2021 •
edited
Loading

  • Updates the file renaming when restoring snapshots, to do os.Rename on windows machines

Logs under current binary, when doing a snapshot save followed by restore
Screen Shot 2021-08-19 at 3 18 26 PM

@ncabatoff ncabatoff added this to the 1.8.2 milestone Aug 19, 2021
@ncabatoff
Copy link
Collaborator

Fixes #12116

@vercel vercel bot temporarily deployed to Preview – vault August 19, 2021 22:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 19, 2021 22:28 Inactive
@pmmukh pmmukh merged commit c30db2c into main Aug 19, 2021
@pmmukh pmmukh deleted the vault-3226-fix-windows-snapshot-bug branch August 19, 2021 23:05
pmmukh added a commit that referenced this pull request Aug 19, 2021
@pmmukh
[VAULT-3226] Use os.rename on windows os (#12377)
c0ed13c 
* [VAULT-3226] Use os.rename on windows os

* [VAULT-3226] Add changelog
pmmukh added a commit that referenced this pull request Aug 19, 2021
@pmmukh
[VAULT-3226] Use os.rename on windows os (#12377)
c053181 
* [VAULT-3226] Use os.rename on windows os

* [VAULT-3226] Add changelog
pmmukh added a commit that referenced this pull request Aug 19, 2021
@pmmukh
[VAULT-3226] Use os.rename on windows os (#12377) (#12381)
51c3aa3 
* [VAULT-3226] Use os.rename on windows os

* [VAULT-3226] Add changelog
pmmukh added a commit that referenced this pull request Aug 20, 2021
@pmmukh
[VAULT-3226] Use os.rename on windows os (#12377)
712b17e 
* [VAULT-3226] Use os.rename on windows os

* [VAULT-3226] Add changelog
pmmukh added a commit that referenced this pull request Aug 20, 2021
@pmmukh
[VAULT-3226] Use os.rename on windows os (#12377) (#12382)
f5c3259 
* [VAULT-3226] Use os.rename on windows os

* [VAULT-3226] Add changelog
@pmmukh pmmukh modified the milestones: 1.8.2, 1.6.6 Aug 20, 2021
mladlow pushed a commit that referenced this pull request Aug 20, 2021
@pmmukh
[VAULT-3226] Use os.rename on windows os (#12377) (#12387)
1085049 
* [VAULT-3226] Use os.rename on windows os

* [VAULT-3226] Add changelog
@pmmukh pmmukh mentioned this pull request Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.6
Development

Successfully merging this pull request may close these issues.
3 participants
@pmmukh @ncabatoff @briankassouf