Expose secret_id_accessor as WrappedAccessor when wrapping secret-id creation.

[melbit-michaelw]

Resolves #12173 for Secret-Ids.

I'm not a Go developer (nor indeed any kind of developer), and was unable to find the right place to add a test for this functionality. Could you please point me in the right direction as to where this should be tested ?

[hashicorp-cla]

All committers have signed the CLA.

[pmmukh]

Hi @melbit-michaelw ! Thanks for submitting this PR! For adding a test for this functionality, I think you are good to skip unit tests, as we don't really have unit tests on wrapping.go. For integration tests, I think adding a new folder for approle under https://github.com/hashicorp/vault/tree/main/vault/external_tests, and adding a test there that exercises setting up a wrapped secret and uses the accessor in the response like how hashicorp/terraform-provider-vault#976 plans to use it, would make sense.

[pmmukh]

Think this comment https://github.com/hashicorp/vault/blob/main/sdk/helper/wrapping/wrapinfo.go#L20-L21 might need to be updated, to reflect the dual nature of WrappedAccessor with this change.

[melbit-michaelw]

Thank you very much for the feedback. I've done the minor fixes suggested, and will start looking at the integration testing.

[melbit-michaelw]

@pmmukh - Added tests to confirm WrappedAccessor set as expected, and not set when wrapping isn't performed.

Let me know if anything else is required.

[pmmukh]

hey! Just wanted to drop a note that there's one little point we're hashing out internally on this change, after which I'll give this another pass sometime this week!

[pmmukh]

lgtm! Thanks for the quick responses on the feedback!