Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 response when looking for a secret_id_accessor that does not exist #12788

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

remilapeyre
Copy link
Contributor

Closes #12660

@remilapeyre remilapeyre requested a review from a team October 10, 2021 17:34
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 17:35 Inactive
@remilapeyre remilapeyre changed the title Return 404 response when looking for an secret_id_accessor that does not exist Return 404 response when looking for a secret_id_accessor that does not exist Oct 10, 2021
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 18:25 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 18:25 Inactive
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/auth/approle/role/<approle>/secret_id_accessor/lookup returns HTTP 500 instead of 404
3 participants