Hide verify-connection attribute on connection config show page #13152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
approved these changes
Nov 16, 2021
hashishaw
added a commit
that referenced
this pull request
Nov 16, 2021
* Hide verify-connection attribute on connection config show page * Add changelog
hashishaw
added a commit
that referenced
this pull request
Nov 16, 2021
* Hide verify-connection attribute on connection config show page * Add changelog
hashishaw
added a commit
that referenced
this pull request
Nov 16, 2021
hashishaw
added a commit
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a misleading UI where
verify_connectionvalue is shown on the database secrets engine connection show page, where it is never returned from the API. Issue #13119 is related to this fix.verify_connectionis only used when saving the connection, so it isn't stored with the other attributes and shouldn't be shown on the connection page.Before, after unchecking "Verify connection":
After, on same connection:
