recognize ed25519 key type and return PKCS8 format #13257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convertRespToPKCS8 does not recognize the ed25519 key. Changes to recognize ed25519 key and return its PKCS8 format
|
Requires #13254 as a base to verify and validate this PR |
stevendpclark
requested changes
Nov 24, 2021
There was a problem hiding this comment.
Great stuff, much appreciated @navaneethrameshan for the second fix in this area!
Could I ask that you rename the changelog file adding a .txt to the filename please?
stevendpclark
approved these changes
Nov 24, 2021
|
Thank you @stevendpclark! Updated the changelog file name. |
stevendpclark
pushed a commit
that referenced
this pull request
Nov 24, 2021
* return pkcs8 format for ed25519 curve convertRespToPKCS8 does not recognize the ed25519 key. Changes to recognize ed25519 key and return its PKCS8 format
stevendpclark
added a commit
that referenced
this pull request
Nov 24, 2021
* return pkcs8 format for ed25519 curve convertRespToPKCS8 does not recognize the ed25519 key. Changes to recognize ed25519 key and return its PKCS8 format Co-authored-by: Navaneeth Rameshan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13256
convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format