-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sudo paths missing from OpenAPI and docs #21772
Merged
Merged
Commits on Jul 12, 2023
-
Fix sudo paths missing from OpenAPI and docs
Various sudo (a.k.a. root-protected) paths are implemented in non-standard ways, and as a result: * are not declared as x-vault-sudo in the OpenAPI spec * and as a result of that, are not included in the hardcoded patterns powering the Vault CLI `-output-policy` flag * and in some cases are missing from the table of all sudo paths in the docs too Fix these problems by: * Adding `seal` and `step-down` to the list of root paths for the system backend. They don't need to be there for enforcement, as those two special endpoints bypass the standard request handling code, but they do need to be there for the OpenAPI generator to be able to know they require sudo. The way in which those two endpoints do things differently can be observed in the code search results for `RootPrivsRequired`: https://github.com/search?q=repo%3Ahashicorp%2Fvault%20RootPrivsRequired&type=code * Fix the implementation of `auth/token/revoke-orphan` to implement endpoint sudo requirements in the standard way. Currently, it has an **incorrect** path declared in the special paths metadata, and then compensates with custom code throwing an error within the request handler function itself.
Configuration menu - View commit details
-
Copy full SHA for 01f87c9 - Browse repository at this point
Copy the full SHA 01f87c9View commit details
Commits on Jul 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f7ca560 - Browse repository at this point
Copy the full SHA f7ca560View commit details
Commits on Jul 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 64530c2 - Browse repository at this point
Copy the full SHA 64530c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed8edc0 - Browse repository at this point
Copy the full SHA ed8edc0View commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b4244c4 - Browse repository at this point
Copy the full SHA b4244c4View commit details
Commits on Jul 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 22b66de - Browse repository at this point
Copy the full SHA 22b66deView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbe23bd - Browse repository at this point
Copy the full SHA bbe23bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1b1fb6 - Browse repository at this point
Copy the full SHA c1b1fb6View commit details -
Co-authored-by: Anton Averchenkov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 651bbae - Browse repository at this point
Copy the full SHA 651bbaeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.