Sync sublogger level with parent #24502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the following commits, subloggers are now able to set their own levels while maintaining a hierarchical relationship to their parent/children.
hashicorp/go-hclog#134
hashicorp/go-hclog#137
This allows us to keep leaf sublogger levels in sync with their parent, unless specifically set otherwise.
As a result, we no longer have to track every leaf logger in the
(Core).allLoggersslice. Instead, we can track main subsystem subloggers inallLoggers(e.g.core.replication), without having to manage every child (e.g.core.replication.index).