Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename physical backend to storage and alias old value #2456

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Mar 8, 2017

No description provided.

@jefferai jefferai added this to the 0.7.0 milestone Mar 8, 2017
@jefferai
Copy link
Member Author

jefferai commented Mar 8, 2017

cc @sethvargo @briankassouf @vishalnayak

If tests pass I'm going to simply merge this but if anyone wants to give a lookover that's great too.

@jefferai jefferai merged commit b1ed578 into master Mar 8, 2017
@jefferai jefferai deleted the physical-backend-to-storage branch March 8, 2017 14:17
} else {
if o := list.Filter("backend"); len(o.Items) > 0 {
if err := parseStorage(&result, o, "backend"); err != nil {
return nil, fmt.Errorf("error parsing 'backend': %s", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jefferai

Do you think we should print out a warning here (and below) telling folks that it's been renamed and will be removed in a future version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethvargo I thought about that but we don't really have that plumbed through right now. Realistically we will never actually remove this so over time people checking docs will just realize that it's called storage now and new users will always call it storage. This might be one of those "when I'm bored" things, to allow returning a warning instead of just an error, or allow sending the output stream into the config parsing function, to print an error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan!

algitbot pushed a commit to alpinelinux/aports that referenced this pull request Oct 9, 2020
 * fix broken web link

 * add api_addr default
    Vault warns at startup if not set
    https://learn.hashicorp.com/tutorials/vault/getting-started-deploy

 * config backend -> storage
   hashicorp/vault#2456
josegonzalez added a commit to josegonzalez/vault that referenced this pull request Dec 15, 2021
This was missing from upgrade docs and implemented in hashicorp#2456.
yhyakuna pushed a commit that referenced this pull request Dec 22, 2021
…#13451)

* docs: add a note regarding the backend => storage config key aliasing

This was missing from upgrade docs and implemented in #2456.

* Update website/content/docs/upgrading/upgrade-to-0.7.0.mdx

Co-authored-by: Loann Le <[email protected]>

Co-authored-by: Loann Le <[email protected]>
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
…hashicorp#13451)

* docs: add a note regarding the backend => storage config key aliasing

This was missing from upgrade docs and implemented in hashicorp#2456.

* Update website/content/docs/upgrading/upgrade-to-0.7.0.mdx

Co-authored-by: Loann Le <[email protected]>

Co-authored-by: Loann Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants