Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing delegated_auth_accessors config field to /sys/mounts/<path> response #26876

Merged
merged 5 commits into from
May 8, 2024

Conversation

stevendpclark
Copy link
Contributor

  • The field hadn't been properly populated in the JSON struct being returned through the API response, but had been properly set in the stored structs in the backend.
  • Add missing update to the command tune docs for the -delegated-auth-accessors option that existed
  • Add -delegated-auth-accessors to the secret enable vault command along with a docs update

…h> response

 - The field hadn't been properly populated in the JSON struct being returned
   through the API response, but had been properly set in the stored structs
   in the backend.
 - Add missing update to the command tune docs for the -delegated-auth-accessors
   option that existed
 - Add -delegated-auth-accessors to the secret enable vault command along with
   a docs update
@stevendpclark stevendpclark added this to the 1.16.3 milestone May 8, 2024
@stevendpclark stevendpclark requested a review from a team May 8, 2024 14:01
@stevendpclark stevendpclark self-assigned this May 8, 2024
@stevendpclark stevendpclark requested a review from a team as a code owner May 8, 2024 14:01
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented May 8, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Left a question, but it does not necessarily warrant changes.

command/secrets_enable.go Show resolved Hide resolved
website/content/docs/commands/secrets/enable.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/secrets/tune.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants