Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix generic v2 secret engine links #27019

Merged
merged 5 commits into from
May 14, 2024

Conversation

hashishaw
Copy link
Contributor

This PR fixes the links for generic engines that were upgraded to V2 so that they can see the correct data.

Before, after upgrading:
image

After
image

@hashishaw hashishaw added this to the 1.16.3 milestone May 14, 2024
@hashishaw hashishaw requested a review from a team as a code owner May 14, 2024 15:34
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 14, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thanks for picking up!

@hashishaw hashishaw merged commit f19e43f into main May 14, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-26860/generic-upgrade-secrets branch May 14, 2024 16:41
hashishaw added a commit that referenced this pull request May 14, 2024
* Update generic upgrade test to reflect user behavior

* Fix backend link for generic v2

* Add redirect for generic v2

* more test coverage

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants