-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ed25519 key type in ca_util #27093
Conversation
CI Results: |
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Is there maybe a unit test we can augment to cover this case?
Unit test would be welcome, there's also a similar error within GetPrivateKeyTypeFromPublicKey. Would you mind addressing that one as well as part of this? Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements? |
I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an |
@@ -0,0 +1,3 @@ | |||
```release-note:bug | |||
pki: Fix error in cross-signing using ed25519 keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pki: Fix error in cross-signing using ed25519 keys | |
secrets/pki: Fix error in cross-signing using ed25519 keys |
Fair, lets not bother for now. |
This PR is to address the error described in issue #26089 with ed25519 keys