Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ed25519 key type in ca_util #27093

Merged
merged 5 commits into from
May 22, 2024
Merged

Fix ed25519 key type in ca_util #27093

merged 5 commits into from
May 22, 2024

Conversation

rculpepper
Copy link
Contributor

This PR is to address the error described in issue #26089 with ed25519 keys

@rculpepper rculpepper requested a review from a team as a code owner May 16, 2024 20:24
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented May 16, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is there maybe a unit test we can augment to cover this case?

@stevendpclark
Copy link
Contributor

Unit test would be welcome, there's also a similar error within GetPrivateKeyTypeFromPublicKey.

Would you mind addressing that one as well as part of this? Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements?

@rculpepper
Copy link
Contributor Author

Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements?

I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an ed25519 key to be a pointer (except the case here)

@@ -0,0 +1,3 @@
```release-note:bug
pki: Fix error in cross-signing using ed25519 keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pki: Fix error in cross-signing using ed25519 keys
secrets/pki: Fix error in cross-signing using ed25519 keys

@stevendpclark
Copy link
Contributor

I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an ed25519 key to be a pointer (except the case here)

Fair, lets not bother for now.

@rculpepper rculpepper added backport/1.14.x backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels May 22, 2024
@rculpepper rculpepper merged commit 0b02c5d into main May 22, 2024
106 of 107 checks passed
@rculpepper rculpepper deleted the rculpepper/pki-ed25519-fix branch May 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants