Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ldap secrets hierarchical paths #27203

Merged
merged 4 commits into from
May 24, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented May 23, 2024

@fairclothjm fairclothjm added this to the 1.17.0-rc milestone May 23, 2024
@fairclothjm fairclothjm requested a review from a team May 23, 2024 17:35
@fairclothjm fairclothjm requested a review from a team as a code owner May 23, 2024 17:35
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 23, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@@ -409,29 +426,6 @@ $ curl \
http://127.0.0.1:8200/v1/ldap/role/dynamic-role
```

### Read dynamic role configuration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved to be grouped with the other /ldap/role/:role_name endpoints since that is more standard practice in the Vault docs.

website/content/api-docs/secret/ldap.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/ldap.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/ldap.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/ldap.mdx Outdated Show resolved Hide resolved
website/content/api-docs/secret/ldap.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/ldap.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/ldap.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/ldap.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/ldap.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/ldap.mdx Outdated Show resolved Hide resolved
@fairclothjm
Copy link
Contributor Author

Thanks @schavis I have made the requested changes

@schavis schavis added the content-lgtm Content changes approved. Merge depends on code review label May 23, 2024
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fairclothjm fairclothjm merged commit f528036 into main May 24, 2024
36 checks passed
@fairclothjm fairclothjm deleted the docs/VAULT-27102/ldap-hierarchical-paths branch May 24, 2024 14:11
@hellobontempo hellobontempo mentioned this pull request Oct 28, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-lgtm Content changes approved. Merge depends on code review hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants