Backport of VAULT-25848 replace mholt/archiver with native go calls into release/1.17.x #27244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/violethynes/VAULT-25848/extremely-brief-cow
branch
from
933f7b0
to
f422760
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
This shouldn't be merged until after the RC is cut and the code freeze is over. |
VioletHynes
approved these changes
May 27, 2024
|
CI Results: |
|
Build Results: |
VioletHynes
deleted the
backport/violethynes/VAULT-25848/extremely-brief-cow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27228 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
This removes the mholt/archiver dependency, and replaces it in the only place where it's used (debug) with native Go calls instead. This passed with the old and new tests.
As far as I can tell, everything works the same. I've added the backport labels as I think I'll need to backport this due to this dependency being flagged as having a vulnerability.
Overview of commits