Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP TLS guide #27318

Merged
merged 12 commits into from
Jun 5, 2024
Merged

Add TCP TLS guide #27318

merged 12 commits into from
Jun 5, 2024

Conversation

jonathanfrappier
Copy link
Contributor

Copy link

github-actions bot commented May 31, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@finnigja finnigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, but overall lgtm.. looking forward to getting this done!

website/content/docs/configuration/listener/tcp-tls.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp-tls.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp-tls.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp-tls.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp-tls.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp-tls.mdx Outdated Show resolved Hide resolved
* recreating edits

* Fix nav entry
Copy link
Contributor

@finnigja finnigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.. thanks for pulling this together!

@jonathanfrappier jonathanfrappier merged commit ef10c1a into main Jun 5, 2024
32 checks passed
@jonathanfrappier jonathanfrappier deleted the docs/add-tcp-tls branch June 5, 2024 13:48
jonathanfrappier added a commit that referenced this pull request Jun 5, 2024
* Add TCP TLS guide

* Fix example listener stanza missing }

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Suggestions for TCP-TLS docs (#27335)

* recreating edits

* Fix nav entry

---------

Co-authored-by: Jamie Finnigan <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
schavis added a commit that referenced this pull request Jun 5, 2024
* Add TCP TLS guide

* Fix example listener stanza missing }

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <[email protected]>

* Suggestions for TCP-TLS docs (#27335)

* recreating edits

* Fix nav entry

---------

Co-authored-by: Jamie Finnigan <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
schavis added a commit that referenced this pull request Jun 5, 2024
* Add TCP TLS guide
* Apply Suggestions for TCP-TLS docs (#27335)

---------

Co-authored-by: Jamie Finnigan <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
schavis added a commit that referenced this pull request Jun 5, 2024
* Add TCP TLS guide
* Apply Suggestions for TCP-TLS docs (#27335)

---------

Co-authored-by: Jonathan Frappier <[email protected]>
Co-authored-by: Jamie Finnigan <[email protected]>
schavis added a commit that referenced this pull request Jun 5, 2024
* Add TCP TLS guide
* Apply Suggestions for TCP-TLS docs (#27335)

---------

Co-authored-by: Jonathan Frappier <[email protected]>
Co-authored-by: Jamie Finnigan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants