Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI check for do-not-merge label #27325

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Add a CI check for do-not-merge label #27325

merged 3 commits into from
Jun 4, 2024

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Jun 3, 2024

This PR adds a new CI check for the do-not-merge label. The check just fails if the label is present.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 3, 2024
@mpalmi mpalmi marked this pull request as ready for review June 3, 2024 15:20
@mpalmi mpalmi requested a review from a team as a code owner June 3, 2024 15:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

VioletHynes
VioletHynes approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this :D

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

@mpalmi mpalmi merged commit e99e887 into main Jun 4, 2024
83 of 84 checks passed
@mpalmi mpalmi deleted the ci/do-no-merge-label branch June 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

@ryancragun ryancragun Awaiting requested review from ryancragun

@marcboudreau marcboudreau Awaiting requested review from marcboudreau

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpalmi @VioletHynes