Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI bug fix: Kubernetes Role filter replace with explicit input filter into release/1.16.x #27326

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #27178 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@Monkeychip
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


  • Ent test pass
  • Test coverage

The UI team has run into various issues with the use of NavigateInput for filtering over a list. Such an issue arose in the Kubernetes Secret Engine, and instead of trying to solve for that component, we moved forward with using the new explicit search pattern.

This PR fixes Issue #27153

Note:

  • I created a template only component that plays off the filterInput component, but as the naming suggests is an explicit filter.
  • Whoever consumes this component should handle the actions in the parent. This approach was encouraged because routing and directories, etc can be very individualized per list view (that's part of what makes NavigateInput a hard component to read — it's doing too much individualized tasks).
  • The other areas we use NavigateInput should also move towards this adoption. I'll write a JIRA ticket for this.

Before

Screen.Recording.2024-05-22.at.10.54.53.AM.mov

After

k8after.mov

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 3, 2024
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

github-actions bot commented Jun 3, 2024

CI Results:
All Go tests succeeded! ✅

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-27414/k8-role-filter/personally-loyal-egret branch 4 times, most recently from 3023056 to 2c9fcfd Compare June 3, 2024 15:46
@Monkeychip Monkeychip closed this Jun 3, 2024
@hellobontempo hellobontempo deleted the backport/ui/VAULT-27414/k8-role-filter/personally-loyal-egret branch July 8, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants