Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing serial number more gracefully #27681

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

sgmiller
Copy link
Contributor

@sgmiller sgmiller commented Jul 3, 2024

Previously, in the default: case of pathFetchRead, not providing the serial
parameter results in a panic when casting the empty result.

@sgmiller sgmiller requested a review from a team as a code owner July 3, 2024 20:28
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 3, 2024
@sgmiller sgmiller added backport/1.17.x backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Jul 3, 2024
@sgmiller sgmiller added this to the 1.18.0-rc milestone Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jul 3, 2024

Build Results:
All builds succeeded! ✅

@sgmiller
Copy link
Contributor Author

sgmiller commented Jul 3, 2024

Not a valid bug, without the PoC code, this can never be hit, as the regex for cert read won't match.

@sgmiller sgmiller closed this Jul 3, 2024
@sgmiller sgmiller reopened this Jul 3, 2024
@sgmiller sgmiller removed backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x labels Jul 3, 2024
@sgmiller sgmiller enabled auto-merge (squash) July 3, 2024 20:44
@sgmiller sgmiller merged commit 30f457f into main Jul 3, 2024
120 of 161 checks passed
@sgmiller sgmiller deleted the sgm/handle-missing-serial branch July 3, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants