Add custom tags section to sync overview, denote normalized values #27757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizing names and tags
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
tvoran
approved these changes
Jul 11, 2024
Co-authored-by: Theron Voran <[email protected]>
robmonte
deleted the
docs/sync-overview-specify-normalization-add-tags-section
branch
6 tasks
robmonte
added a commit
that referenced
this pull request
Jul 11, 2024
…27757) * Add custom tags section to sync overview, specifically call out normalizing names and tags * Update website/content/docs/sync/index.mdx Co-authored-by: Theron Voran <[email protected]> * Fix typo --------- Co-Authored-By: Theron Voran <[email protected]>
robmonte
added a commit
that referenced
this pull request
Jul 11, 2024
…27757) (#27762) * Add custom tags section to sync overview, specifically call out normalizing names and tags * Update website/content/docs/sync/index.mdx * Fix typo --------- Co-authored-by: Theron Voran <[email protected]>
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
…27757) * Add custom tags section to sync overview, specifically call out normalizing names and tags * Update website/content/docs/sync/index.mdx Co-authored-by: Theron Voran <[email protected]> * Fix typo --------- Co-authored-by: Theron Voran <[email protected]>
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
…27757) * Add custom tags section to sync overview, specifically call out normalizing names and tags * Update website/content/docs/sync/index.mdx Co-authored-by: Theron Voran <[email protected]> * Fix typo --------- Co-authored-by: Theron Voran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a section about custom tags to the secrets sync overview. Also specifically calls out text that is normalized for syncing (secret names, tag keys and values).
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.