Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update date-picker UX in Client Counts #27796

Merged
merged 14 commits into from
Jul 17, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jul 16, 2024

Description

This PR replaces the previous date range experience -- which had separate areas for updating the billing start date vs the filtered end date for the data -- with a single place to update the date range for the client count information.

After
Edit date range modal

CE experience when landing on dashboard:
image

Date Range Validation
image
image

Before
Client Counts - Before

  • Ent tests pass

@hashishaw hashishaw added the ui label Jul 16, 2024
@hashishaw hashishaw added this to the 1.18.0-rc milestone Jul 16, 2024
@hashishaw hashishaw requested a review from a team as a code owner July 16, 2024 19:44
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jul 16, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work! Extremely clean implementation 🤩

Just a couple comment that are very unimportant. Biggest question is how this will look for CE when no start_time is available. I'll pick up reviewing tomorrow with a fresh brain!

ui/app/components/clients/date-range.js Outdated Show resolved Hide resolved
ui/app/components/clients/date-range.js Outdated Show resolved Hide resolved
ui/app/components/clients/date-range.js Outdated Show resolved Hide resolved
ui/app/components/clients/date-range.hbs Outdated Show resolved Hide resolved
ui/app/components/clients/date-range.hbs Outdated Show resolved Hide resolved
ui/app/components/clients/date-range.hbs Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye felicia 👋

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✨

class="hds-form-text-input"
type="month"
value={{this.startDate}}
max={{this.currentMonth}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@hashishaw hashishaw merged commit 050a90b into main Jul 17, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-28936/replace-date-range-ux-cc branch July 17, 2024 16:48
Monkeychip pushed a commit that referenced this pull request Jul 24, 2024
* Create date-range component with tests

* update selectors and callback behavior

* update cc tests & selectors

* cleanup

* RIP calendar-widget and date-dropdown -- you were good components

* reset on close

* Add changelog

* use parseApiTimestamp

* fix test

* cleanup

* make date-range typescript, update behavior

* add words

* minor styling

* fix test
Monkeychip pushed a commit that referenced this pull request Jul 24, 2024
* Create date-range component with tests

* update selectors and callback behavior

* update cc tests & selectors

* cleanup

* RIP calendar-widget and date-dropdown -- you were good components

* reset on close

* Add changelog

* use parseApiTimestamp

* fix test

* cleanup

* make date-range typescript, update behavior

* add words

* minor styling

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants