UI: add subkey request to kv v2 adapter #27804
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
| @@ -10,7 +10,7 @@ | |||
| data-test-overview-card-container={{@cardTitle}} | |||
| ...attributes | |||
| > | |||
| <div class="flex row-wrap space-between has-bottom-margin-m" data-test-overview-card={{@cardTitle}}> | |||
There was a problem hiding this comment.
Although this affects overview cards everywhere, it's a very small change and I'd rather the spacing be consistent across the board than have different padding situations.
| @@ -10,7 +10,7 @@ | |||
| data-test-overview-card-container={{@cardTitle}} | |||
| ...attributes | |||
| > | |||
| <div class="flex row-wrap space-between has-bottom-margin-m" data-test-overview-card={{@cardTitle}}> | |||
| <div class="flex row-wrap space-between has-bottom-margin-s" data-test-overview-card={{@cardTitle}}> | |||
| Copyright (c) HashiCorp, Inc. | ||
| SPDX-License-Identifier: BUSL-1.1 | ||
| ~}} | ||
|
|
| @@ -98,6 +99,10 @@ | |||
| margin: $spacing-4 0; | |||
| } | |||
|
|
|||
| .has-top-bottom-margin-12 { | |||
There was a problem hiding this comment.
since this is a new class, I opted to use the updated -12 number naming which is a pattern we had discussed moving towards (and away from s, m, l) happy to revert and make this -s if folks prefer
There was a problem hiding this comment.
Can you just add a comment here to that affect? That this is the pattern we want to move toward, away from s/m/l so that future code-browsers will not be confused by the different types of measurements
There was a problem hiding this comment.
Yes, good idea! Will add
| {{/if}} | ||
|
|
||
| {{! Use the "subtext" yield for stylized subtext or including elements like doc links. }} | ||
| {{#if (has-block "subtext")}} |
There was a problem hiding this comment.
I didn't want to update @subText for all OverviewCards, I felt like it made sense to keep both potential use cases. 1) just text subtext and 2) more stylized content, such as inline links
There was a problem hiding this comment.
Are @subtext and <:subtext> mutually exclusive? Right now passing both with yield both
There was a problem hiding this comment.
I intentionally made them not mutually exclusive as I didn't see a reason for them to be. Someone could add subtext in the default styling and then add a second stylized block. What do you think?
There was a problem hiding this comment.
Makes sense to me! I think the most confusing part is that they are named the same thing, so it felt like maybe they should be mutually exclusive. But, naming is hard 🤷
ui/app/adapters/kv/data.js
Outdated
| // TODO use query-param-string util when https://github.com/hashicorp/vault/pull/27455 is merged | ||
| fetchSubkeys(query) { | ||
| const { backend, path, version, depth } = query; | ||
| const apiPath = buildKvPath(backend, path, 'subkeys'); // encodes mount and secret paths |
There was a problem hiding this comment.
Any reason you didn't export a kvSubkeyPath method instead of using the base helper? Then the version and query params logic could be in there as well, and easy to unit test
There was a problem hiding this comment.
Since this endpoint isn't implemented yet, it was easier for my brain to fiddle with and update the logic in one place. I can move this into a kvSubkeyPath helper. The adapter unit test felt sufficient for testing, but I can add another test for the util.
Also the default args for this endpoint work a little differently since we always send a depth param but not always a version param, so I can't use the version logic out of the box from buildKvPath
| @@ -98,6 +99,10 @@ | |||
| margin: $spacing-4 0; | |||
| } | |||
|
|
|||
| .has-top-bottom-margin-12 { | |||
There was a problem hiding this comment.
Can you just add a comment here to that affect? That this is the pattern we want to move toward, away from s/m/l so that future code-browsers will not be confused by the different types of measurements
| {{/if}} | ||
|
|
||
| {{! Use the "subtext" yield for stylized subtext or including elements like doc links. }} | ||
| {{#if (has-block "subtext")}} |
There was a problem hiding this comment.
Are @subtext and <:subtext> mutually exclusive? Right now passing both with yield both
Description
Adds the subkey component and request to the kv data adapter. There are no user facing changes in this PR.
✅ enterprise tests
JSON off (default) 📸
JSON on 📸