Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Audit: log 'warnings' from eventlogger even if audit is deemed a success into release/1.17.x #27813

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #27809 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

The below text is copied from the body of the original PR.


Description

Within audit there exists an scenario where the eventlogger broker reports that audit was deemed a success (because it managed to successfully log to at least 1 sink node), but there were warnings (errors) that came back from other audit devices where audit failed.

We want to ensure that we capture these warnings in the server log so that they don't go missing because we managed to log to a single device.

This PR has ENT and CE components.

HashiCorp Checklist

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/peteski22/audit/log-all-warnings/eminently-hardy-rhino branch from 7315bb4 to e4a02d6 Compare July 19, 2024 10:13
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 19, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jul 19, 2024

CI Results:
All Go tests succeeded! ✅

@peteski22 peteski22 added this to the 1.17.3 milestone Jul 19, 2024
@peteski22 peteski22 merged commit 2be7e0e into release/1.17.x Jul 19, 2024
79 of 80 checks passed
@peteski22 peteski22 deleted the backport/peteski22/audit/log-all-warnings/eminently-hardy-rhino branch July 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants