Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Count Docs Updates/Cleanup #27862

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Client Count Docs Updates/Cleanup #27862

merged 6 commits into from
Aug 6, 2024

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Jul 24, 2024 •
edited
Loading

Description

Client count documentation updates.

The main objectives:

  • Remove any version related descriptions; the docs team wants to train customers to use the versioned docs for this information.
  • Try to condense multiple bullets into as few as possible.
  • Remove repetitive information, and remedy any incorrect information.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@divyaac divyaac requested a review from a team as a code owner July 24, 2024 20:32
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 24, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

divyaac
divyaac commented Jul 24, 2024
View reviewed changes
website/content/api-docs/system/internal-counters.mdx
For example, if the billing period is from Jan 2022 to June 2022, and the
activity subsystem in Vault was not capturing data for the months Jan to March,
the response will only include information for May and June. Note that if no
`start_time` and `end_time` parameters are specified, the billing period defaults
Copy link
Contributor Author

@divyaac divyaac Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this start_time/end_time information because it duplicates info at the bottom when we explain the parameters at the bottom with the API.

divyaac
divyaac commented Jul 24, 2024
View reviewed changes
website/content/api-docs/system/internal-counters.mdx
- The `distinct_entities` field name has been deprecated since Vault 1.10. Refer to
`entity_clients` field instead. The `distinct_entities` field is currently
returned by the API for backward compatibility and it may be removed in the future.
- The response includes month data for the entire queried period, but may
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the confusion in this thread

@divyaac divyaac added this to the 1.18.0-rc milestone Jul 24, 2024
@divyaac divyaac added the docs label Jul 24, 2024
@divyaac divyaac force-pushed the VAULT-28763_Client_Count_Docs_Updates branch from b6b2f9c to 4fa1896 Compare July 25, 2024 22:37
@divyaac divyaac requested a review from miagilepner July 25, 2024 22:37
miagilepner
miagilepner approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should also get @schavis's approval before merging

@divyaac divyaac merged commit 8a5ae2b into main Aug 6, 2024
36 of 37 checks passed
@divyaac divyaac deleted the VAULT-28763_Client_Count_Docs_Updates branch August 6, 2024 22:59
akshya96 pushed a commit that referenced this pull request Aug 7, 2024
@divyaac @miagilepner @akshya96
Client Count Docs Updates/Cleanup (#27862)
84b499c 
* Docs changes

* More condensation of docs

* Added some clarity on date ranges

* Edited wording'

* Added estimation client count info

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: miagilepner <[email protected]>
Monkeychip pushed a commit that referenced this pull request Aug 9, 2024
@divyaac @miagilepner @Monkeychip
Client Count Docs Updates/Cleanup (#27862)
a260f26 
* Docs changes

* More condensation of docs

* Added some clarity on date ranges

* Edited wording'

* Added estimation client count info

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: miagilepner <[email protected]>
miagilepner added a commit that referenced this pull request Aug 15, 2024
@divyaac @miagilepner
Client Count Docs Updates/Cleanup (#27862)
823404a 
* Docs changes

* More condensation of docs

* Added some clarity on date ranges

* Edited wording'

* Added estimation client count info

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: miagilepner <[email protected]>
miagilepner added a commit that referenced this pull request Aug 15, 2024
@miagilepner @divyaac
1.17 Manual backport: Current month inconsistencies (#28088)
472ab96 
* Handle Query Updates (#27547)

* Simplify handle query to return updated estimation values

* Added changelog

* remove comment

* Revert "Simplify handle query to return updated estimation values"

This reverts commit b67969c.

* temp

* Revert "temp"

This reverts commit 4932979.

* CE files handle query update

* Revert "CE files handle query update"

This reverts commit 8dafa2d.

* CE Changes

* Delete vault/external_tests/upgrade_testing/upgrade_testing_binary/upgrade_test.go

* Sort namespaces, mounts, and clients before adding them to HLL (#28062)

* sort namespaces and mounts before adding them

* also sort clients

* add comments

* pr comment fixes

* changelog

* changelog update

* cleanup after handlequery changes (#27776)

* Show Current Month When Future Month Start Date is Provided (#28042)

* Show current month data

* Added changelog

* Edited changelog

* Client Count Docs Updates/Cleanup (#27862)

* Docs changes

* More condensation of docs

* Added some clarity on date ranges

* Edited wording'

* Added estimation client count info

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: divyaac <[email protected]>
akshya96 added a commit that referenced this pull request Aug 20, 2024
@akshya96 @ryancragun
@bear359 @tvoran @banks @schavis @miagilepner @sgmiller @hashishaw @divyaac @romanobrien @sofixa @digivava @eltociear @owenzorrin @gkoutsou @hellobontempo @dependabot @jonathanfrappier @yhyakuna @Monkeychip @bmaximuml @fe80
Auto-roll billing start enos test (#27981)
76a49a5 
* auto-roll billing start enos test

* enos: don't expect curl available in docker image (#27984)

Signed-off-by: Ryan Cragun <[email protected]>

* Update interoperability-matrix.mdx (#27977)

Updating the existing Vault/YubiHSM integration with a newer version of Vault as well as now supporting Managed Keys.

* Update hana db pkg (#27950)

* database/hana: use go-hdb v1.10.1

* docs/hana: quotes around password so dashes don't break it

* Clarify audit log failure telemetry docs. (#27969)

* Clarify audit log failure telemetry docs.

* Add the note about the misleading counts

* Auto-rolling billing start docs PR  (#27926)

* auto-roll docs changes

* addressing comments

* address comments

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: Sarah Chavis <[email protected]>

* addressing some changes

* update docs

* update docs with common explanation file

* updated note info

* fix 1.18 upgrade doc

* fix content-check error

* Update website/content/partials/auto-roll-billing-start-example.mdx

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: miagilepner <[email protected]>

* docker: add upgrade notes for curl removal (#27995)

Signed-off-by: Ryan Cragun <[email protected]>

* Update vault-plugin-auth-jwt to v0.21.1 (#27992)

* docs: fix upgrade 1.16.x (#27999)

Signed-off-by: Ryan Cragun <[email protected]>

* UI: Add unsupportedCriticalCertExtensions to jwt config expected payload (#27996)

* Client Count Docs Updates/Cleanup (#27862)

* Docs changes

* More condensation of docs

* Added some clarity on date ranges

* Edited wording'

* Added estimation client count info

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: miagilepner <[email protected]>

* update(kubernetes.mdx): k8s-tokenreview URL (#27993)

Co-authored-by: akshya96 <[email protected]>

* Update programmatic-management.mdx to clarify Terraform prereqs (#27548)

* UI: Replace getNewModel with hydrateModel when model exists (#27978)

* Replace getNewModel with hydrateModel when model exists

* Update getNewModel to only handle nonexistant model types

* Update test

* clarify test

* Fix auth-config models which need hydration not generation

* rename file to match service name

* cleanup + tests

* Add comment about helpUrl method

* Changelog for 1.17.3, 1.16.7 enterprise, 1.15.13 enterprise (#28018)

* changelog for 1.17.3, 1.16.7 enterprise, 1.15.13 enterprise

* Add spacing to match older changelogs

* Fix typo in variables.tf (#27693)

intialize -> initialize

Co-authored-by: akshya96 <[email protected]>

* Update 1_15-auto-upgrade.mdx (#27675)

* Update 1_15-auto-upgrade.mdx

* Update known issue version numbers for AP issue

---------

Co-authored-by: Sarah Chavis <[email protected]>

* Update 1_16-default-policy-needs-to-be-updated.mdx (#27157)

Made a few grammar changes plus updating term from Vault IU to Vault UI

* change instances variable to hosts

* for each hosts

* add cluster addr port

* Add ENVs using NewTestDockerCluster (#27457)

* Add ENVs using NewTestDockerCluster

Currently NewTestDockerCluster had no means for setting any
environment variables. This makes it tricky to create test
for functionality that require thems, like having to set
AWS environment variables.

DockerClusterOptions now exposes an option to pass extra
enviroment variables to the containers, which are appended
to the existing ones.

* adding changelog

* added test case for setting env variables to containers

* fix changelog typo; env name

* Update changelog/27457.txt

Co-authored-by: akshya96 <[email protected]>

* adding the missing copyright

---------

Co-authored-by: akshya96 <[email protected]>

* UI: Build KV v2 overview page (#28106)

* move date-from-now helper to addon

* make overview cards consistent across engines

* make kv-paths-card component

* remove overview margin all together

* small styling changes for paths card

* small selector additions

* add overview card test

* add overview page and test

* add default timestamp format

* cleanup paths test

* fix dateFromNow import

* fix selectors, cleanup pki selectors

* and more selector cleanup

* make deactivated state single arg

* fix template and remove @isDeleted and @isDestroyed

* add test and hide badge unless deactivated

* address failings from changing selectors

* oops, not ready to show overview tab just yet!

* add deletionTime to currentSecret metadata getter

* Bump actions/download-artifact from 4.1.7 to 4.1.8 (#27704)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@65a9edc...fa0a91b)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: akshya96 <[email protected]>

* Bump actions/setup-node from 4.0.2 to 4.0.3 (#27738)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@60edb5d...1e60f62)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: akshya96 <[email protected]>

* Add valid IP callout (#28112)

Co-authored-by: Yoko Hyakuna <[email protected]>

* Refactor SSH Configuration workflow (#28122)

* initial copy from other #28004

* pr feedback

* grr

* Bump browser-actions/setup-chrome from 1.7.1 to 1.7.2 (#28101)

Bumps [browser-actions/setup-chrome](https://github.com/browser-actions/setup-chrome) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/browser-actions/setup-chrome/releases)
- [Changelog](https://github.com/browser-actions/setup-chrome/blob/master/CHANGELOG.md)
- [Commits](browser-actions/setup-chrome@db1b524...facf10a)

---
updated-dependencies:
- dependency-name: browser-actions/setup-chrome
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: divyaac <[email protected]>

* Bump vault-gcp-secrets-plugin (#28089)

Co-authored-by: divyaac <[email protected]>

* docs: correct list syntax (#28119)

Co-authored-by: divyaac <[email protected]>

* add semgrepconstraint check in skip step

---------

Signed-off-by: Ryan Cragun <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Ryan Cragun <[email protected]>
Co-authored-by: Adam Rowan <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Paul Banks <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: miagilepner <[email protected]>
Co-authored-by: Scott Miller <[email protected]>
Co-authored-by: Chelsea Shaw <[email protected]>
Co-authored-by: divyaac <[email protected]>
Co-authored-by: Roman O'Brien <[email protected]>
Co-authored-by: Adrian Todorov <[email protected]>
Co-authored-by: VAL <[email protected]>
Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Co-authored-by: Owen Zhang <[email protected]>
Co-authored-by: gkoutsou <[email protected]>
Co-authored-by: claire bontempo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Frappier <[email protected]>
Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Angel Garbarino <[email protected]>
Co-authored-by: Max Levine <[email protected]>
Co-authored-by: Steffy Fort <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhyakuna yhyakuna yhyakuna approved these changes

@miagilepner miagilepner miagilepner approved these changes

@schavis schavis Awaiting requested review from schavis

Assignees
No one assigned
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.18.0-rc
Development

Successfully merging this pull request may close these issues.
3 participants
@divyaac @miagilepner @yhyakuna