Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of VAULT-28329: Fix months activity log counts when querying for a namespace into release/1.17.x #28104

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #27790 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

The below text is copied from the body of the original PR.


Description

Previously, when you queried the activity log from a namespace you would get the following responses:

{
  "by_namespace": [{...}], // filtered by the request namespace
  "months": [{
    "counts": {...}, // NOT filtered
    "namespaces": [{...}], // filtered by the request namespace
    "new_clients": {
      "counts: {...}, // NOT filtered
      "namespaces": [{...}], // filtered by the request namespace
    }
  }],
  "total": {...} // filtered by the request namespace
}

This was very confusing, and also makes the UI a bad experience if you try to look at only one namespace.

This PR fixes this for the /activity and /activity/monthly endpoints.

Ent PR: https://github.com/hashicorp/vault-enterprise/pull/6260

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/miagilepner/namespace-query-counts/strongly-nearby-dragon branch from 6b1933d to b4818f9 Compare August 16, 2024 15:13
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 16, 2024
@miagilepner miagilepner added this to the 1.17.4 milestone Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner merged commit d827833 into release/1.17.x Aug 19, 2024
74 of 77 checks passed
@miagilepner miagilepner deleted the backport/miagilepner/namespace-query-counts/strongly-nearby-dragon branch August 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants