Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: add auth and secret block to response test for hmac #28283

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

peteski22
Copy link

@peteski22 peteski22 commented Sep 5, 2024

Description

Add test to prevent regression of HMAC for auth within a response for audit.

Related PR: #28236

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@peteski22 peteski22 added core/audit pr/no-changelog hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed backport/1.17.x labels Sep 5, 2024
@peteski22 peteski22 added this to the 1.17.6 milestone Sep 5, 2024
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Pete!

Copy link

github-actions bot commented Sep 5, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Sep 5, 2024

CI Results:
All Go tests succeeded! ✅

@peteski22 peteski22 merged commit 3be1719 into main Sep 5, 2024
105 checks passed
@peteski22 peteski22 deleted the VAULT-30602/audit/hmac-resp-auth-test branch September 5, 2024 11:26
@peteski22 peteski22 added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17.x core/audit hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants