Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate token lease TTL using tune config #28498

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Sep 24, 2024

Description

The max_lease_ttl config of the token backend is not used to constrain a token's TTL when creating a token directly using the auth/token/create endpoint. Instead, the system level default is used.

This PR introduces a fix that calculates a token's TTL by using the tuned max_lease_ttl value.

ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6706

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

CI Results:
All Go tests succeeded! ✅

@ccapurso ccapurso added this to the 1.18.0 milestone Sep 24, 2024
@ccapurso ccapurso marked this pull request as ready for review September 24, 2024 18:23
Copy link

Build Results:
All builds succeeded! ✅

@ccapurso ccapurso merged commit f0782ee into main Sep 24, 2024
104 of 130 checks passed
@ccapurso ccapurso deleted the vault-28314-token-max-lease-ttl-fix branch September 24, 2024 19:29
@ccapurso ccapurso added backport/ent/1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants