Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove parallel command for running tests on github #28499

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hellobontempo
Copy link
Contributor

Description

In 1.18 we removed running the tests in parallel to address test flakiness #28262. We seem to be seeing similar flakiness in 1.17, hoping removing this command (even though it will make running test 1.5 times longer) reduces flakes.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo requested a review from a team as a code owner September 24, 2024 18:52
@hellobontempo hellobontempo changed the title remove parallel command for running tests on github UI: Remove parallel command for running tests on github Sep 24, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 24, 2024
@hellobontempo hellobontempo added this to the 1.17.6 milestone Sep 24, 2024
Copy link

Build Results:
All builds succeeded! ✅

@hellobontempo hellobontempo enabled auto-merge (squash) September 24, 2024 18:59
Copy link

CI Results: failed ❌

@tomcf-hcp tomcf-hcp enabled auto-merge (squash) September 24, 2024 19:32
@tomcf-hcp tomcf-hcp merged commit 56a9038 into release/1.17.x Sep 24, 2024
24 of 28 checks passed
@tomcf-hcp tomcf-hcp deleted the ui/remove-running-tests-in-parallel branch September 24, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants