Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: upgrade HDS to 4.13.0 #28709

Merged
merged 1 commit into from
Oct 17, 2024
Merged

UI: upgrade HDS to 4.13.0 #28709

merged 1 commit into from
Oct 17, 2024

Conversation

alex-ju
Copy link
Member

@alex-ju alex-ju commented Oct 15, 2024

Description

Upgrading HDS to the latest @hashicorp/[email protected]. Fast follow-up on #28525.

For context, 4.10.0 introduced a change in the Dropdown behavior (the list content was preserved in the DOM) that was reverted in 4.13.0. Raising this PR to prevent any potential unexpected impact on end-users, although there are no issues surfaced by manual and automated testing in vault.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 15, 2024
@alex-ju alex-ju changed the title Bump HDS to 4.13 pre-release Test HDS 4.13 Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

CI Results:
All Go tests succeeded! ✅

@alex-ju alex-ju closed this Oct 15, 2024
@alex-ju alex-ju deleted the alex-ju/test-hds-4-13 branch October 15, 2024 14:52
@alex-ju alex-ju restored the alex-ju/test-hds-4-13 branch October 17, 2024 13:14
@alex-ju alex-ju changed the title Test HDS 4.13 UI: upgrade HDS to 4.13.0 Oct 17, 2024
@alex-ju alex-ju reopened this Oct 17, 2024
@alex-ju alex-ju added this to the 1.19.0-rc milestone Oct 17, 2024
@alex-ju alex-ju marked this pull request as ready for review October 17, 2024 13:45
@alex-ju alex-ju requested a review from a team as a code owner October 17, 2024 13:45
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hellobontempo hellobontempo merged commit 0ab970c into main Oct 17, 2024
60 of 64 checks passed
@hellobontempo hellobontempo deleted the alex-ju/test-hds-4-13 branch October 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants