Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Remove decodeURIComponent method for KVv2 secret path on list view into release/1.18.x #28724

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28698 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@Monkeychip
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Fixes Issue #25905.

Previously, the KVv2 secretPath was run through a decodeURIComponent method while rendering the list view. This method found percent encoded data-octets and decoded them. In practice this means that something like %2f would decode to / . This is problematic for a user not intending to make a directory during path name creation but include the %2f as part of the path name.

This fix only applies to KVv2 because KVv1, Cubbyhole, etc pull the path name from the url where the URL is already encoded so decoding something like hello%252fmeep would equal hello%2fmeep. Note: there is another bug I where these engines cannot render the create page on initial transitions for paths that contain data-octets. I've ticketed this bug and will address in a separate PR.

  • Confirmed does not regress PR fix for a similar URL decoding issue.
  • Added test coverage
  • Ent tests pass

Video of before fix and after fix

Screen.Recording.2024-10-15.at.9.07.25.AM.mov

Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 16, 2024
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip closed this Oct 17, 2024
@Monkeychip Monkeychip deleted the backport/ui/VAULT-31680/kvv2-url-encoded-paths/inherently-charmed-monitor branch October 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants