Backport of Remove decodeURIComponent method for KVv2 secret path on list view into release/1.18.x #28724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #28698 to be assessed for backporting due to the inclusion of the label backport/1.18.x.
🚨
The person who merged in the original PR is:
@Monkeychip
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Fixes Issue #25905.
Previously, the KVv2 secretPath was run through a
decodeURIComponent
method while rendering the list view. This method found percent encoded data-octets and decoded them. In practice this means that something like%2f
would decode to/
. This is problematic for a user not intending to make a directory during path name creation but include the%2f
as part of the path name.This fix only applies to KVv2 because KVv1, Cubbyhole, etc pull the path name from the url where the URL is already encoded so decoding something like
hello%252fmeep
would equalhello%2fmeep
. Note: there is another bug I where these engines cannot render the create page on initial transitions for paths that contain data-octets. I've ticketed this bug and will address in a separate PR.Video of before fix and after fix
Screen.Recording.2024-10-15.at.9.07.25.AM.mov
Overview of commits