Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code folding of resources does not correctly handle inline HEREDOC blocks #48

Closed
domhnallw opened this issue Jan 24, 2018 · 2 comments
Closed

Comments

@domhnallw
Copy link

When viewing a resource in a Terraform file, if it contains a HEREDOC block (for example, an IAM policy), the code folding doesn't work - the closing curly brace is correctly matched but when folding the resource the HEREDOC block remains unfolded.

Unfolded:

image

Folded:

image

VSCode version: 1.19.2, x64, Linux (Ubuntu 16.04)
plugin version: mauve.terraform 0.0.20

@domhnallw domhnallw changed the title Code folding of resources does not correctly handle inline HEREDOC inline blocks Code folding of resources does not correctly handle inline HEREDOC blocks Jan 24, 2018
@mauve
Copy link
Contributor

mauve commented Mar 9, 2018

thanks for reporting this bug, I will try and see if I can figure out how to solve it, this should be possible to do using just the configuration so if somebody wants to give it a try, all help is greatly appreciated

@mauve
Copy link
Contributor

mauve commented Jun 19, 2018

this has previously been impossible to implement (I think) but should now be possible to implement using FoldingRangeProvider

@mauve mauve closed this as completed in e39d8db Jul 27, 2018
mauve added a commit that referenced this issue Jul 28, 2018
Closes #48
Closes #107
Closes #102
Closes #103
Closes #112
Closes #106
@ghost ghost locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants