Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Snapshot/Restore APIs #723

Merged
merged 22 commits into from
Nov 2, 2020
Merged

Snapshot/Restore APIs #723

merged 22 commits into from
Nov 2, 2020

Conversation

mitchellh
Copy link
Contributor

@mitchellh mitchellh commented Oct 29, 2020

Details are in RFC WP-039.

This is only the APIs to implement snapshot/restore. I'll implement the CLI in a future PR.

Importantly, the restore is a stage restore operation currently and not a full online restore. It requires the server to be restarted to complete the restore.

@github-actions github-actions bot added the core label Oct 29, 2020
@mitchellh mitchellh added this to the 0.2.0 milestone Oct 29, 2020
Copy link
Contributor

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing about the naming of the last chunk before the trailer.

internal/server/proto/server.proto Outdated Show resolved Hide resolved
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a few open questions around a few log messages to ease some debugging woes in the future, but I don't think they should block merge if the changes don't make sense 👍

internal/server/singleprocess/state/snapshot.go Outdated Show resolved Hide resolved
internal/server/singleprocess/state/snapshot.go Outdated Show resolved Hide resolved
internal/server/singleprocess/state/snapshot.go Outdated Show resolved Hide resolved
@mitchellh mitchellh merged commit 6895d60 into main Nov 2, 2020
@mitchellh mitchellh deleted the f-snapshot branch November 2, 2020 23:57
@mitchellh mitchellh mentioned this pull request Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants