Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images task #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Images task #79

wants to merge 2 commits into from

Conversation

podviaznikov
Copy link
Member

Extracted this plugin from my other experimental project.
Should be used with the following structure:

  • create folder for each page
  • put markdown file and images inside each folder
  • after using markdown task and images task images data would be available under :images key on the post metadata

Not fully tested it. Need to create proper example

@nicorikken
Copy link
Contributor

Would love ❤️ this for the Asciidoctor plugin. There the asciidoctor-diagram extension can render images from inline source. Rendered SVG's can optionally be included in the HTML (powerful feature!!), but otherwise external images (.png, .svg) will be created. The filename can be specified by the user, but I'm not sure if this can extend to outside of the file's directory.

@nicorikken
Copy link
Contributor

I'd like a sample project or concrete example for this PR, because the Asciidoctor could benefit from this as well. I can probably scan the AST of the document to find the linked images, as well as the generated images, and then add them to the metadata. I guess I can benefit from a better understanding on the file management as a whole.

@nicorikken
Copy link
Contributor

@podviaznikov How does this relate to the content-task framework? Perhaps the image handling in the content-task can be improved instead of a separate task?

@allentiak
Copy link
Contributor

Hi, @podviaznikov,

What's the current status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants