Skip to content

Commit

Permalink
Remove strict data from servant{,-server}'s cabal files (#1781)
Browse files Browse the repository at this point in the history
* Remove strict data from servant{,-server}'s cabal files

This has triggered a regression in 0.20.2, and closes #1780

* Restore changelog-d configuration
  • Loading branch information
tchoutri authored Sep 4, 2024
1 parent 6014370 commit 1e3cbee
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 2 deletions.
11 changes: 11 additions & 0 deletions changelog.d/config
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
-- Possible fields for changelog entry
-- synopsis: Brief description of the change. Often just the PR title.
-- description: Longer description, with a list of sub-changes. Not needed for small/atomic changes.
-- packages: Packages affected by the change. Omit if it's an overarching or non-package change.
-- prs: Space-separated hash-prefixed pull request numbers containing the change (usually just one).
-- issues: Space-separated hash-prefixed issue numbers that the change fixes/closes/affects.
-- significance: Set to significant if the change is significant, that is if it warrants being put near the top of the changelog.
organization: haskell-servant
repository: servant
required-fields: synopsis description prs
packages: servant servant-server servant-client-core servant-client servant-quickcheck servant
10 changes: 10 additions & 0 deletions changelog.d/issue-1780
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
synopsis: Remove -XStrictData from servant{,-server}'s cabal files
packages: servant servant-server
prs: #1781
issues: #1780
significance: significant
description: {
The addition of -XStrictData to servant.cabal and servant-server.cabal reduced the laziness
of routing, which would trigger unimplemented endpoints using `error` or `undefined`,
despite the fact that these endpoints themselves were not queried.
}
1 change: 0 additions & 1 deletion servant-server/servant-server.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ common extensions
RankNTypes
RecordWildCards
ScopedTypeVariables
StrictData
TupleSections
TypeApplications
TypeFamilies
Expand Down
1 change: 0 additions & 1 deletion servant/servant.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ common extensions
RankNTypes
RecordWildCards
ScopedTypeVariables
StrictData
TupleSections
TypeApplications
TypeFamilies
Expand Down

0 comments on commit 1e3cbee

Please sign in to comment.